19:03:41 #startmeeting 19:03:41 Let the Jenkins meeting commence! 19:04:00 #info https://wiki.jenkins-ci.org/display/JENKINS/Governance+Meeting+Agenda 19:04:07 #chair abayer hare_brain rtyler 19:04:07 Current chairs: abayer hare_brain kohsuke rtyler 19:04:48 #topic recap of actions 19:04:52 #info http://meetings.jenkins-ci.org/jenkins/2012/jenkins.2012-01-25-19.00.html 19:05:05 jieryn: ndeloof: ping 19:05:24 In the mean time, 19:05:54 #info my apologies about the SSL certs. renewal of SSL certificates is in progress, pending approval from rtyler (the domain contact) 19:06:00 Cool. 19:06:05 most likely it won't happen until he lands to SFO 19:06:18 Poor rtyler appear to have missed his flight back to the US 19:06:33 JIRA/Wiki are updated so that one is complete 19:06:55 OK, I don't think jieryn and ndeloof are here, but 19:07:09 wrt the "FOSS requirement for sponsor logo" thing, 19:07:32 I know Sacha (our boss) said we'd be very happy to be just listed in the sponsor section like other companies 19:08:04 So I think it's now up to jieryn to play with it and come back to this meeting 19:08:27 I think I shall move on to the next topic... 19:08:37 hoy 19:08:45 #topic Pull requests and inbound contributor funnel discussion 19:09:39 This started in my e-mail 19:09:41 That reminds me, I have to set up pull request notification for jenkins-scripts... 19:09:56 "pull request notification"? 19:10:27 Team stuff. I created the repo manually. =) 19:10:54 but anyway, the basic "issue" is that the change of workflow between SVN and GitHub is narrowing the funnel from pull request contributors to committers 19:11:16 Pull request is bit like throwing the stuff over the wall 19:11:40 #info I've actually been meaning to go through the org teams and repos and (a) update the teams to reflect the contributors (including people with multiple pull requests) of the teams and tie the teams to repos more accurately and narrowly. 19:11:59 …so as to make pull request emails more meaningful/less spammy. 19:12:04 They expect us to review & merge, but often we don't have enough people/eyes/time to properly look at them 19:13:07 Is this a better situation than the SVN model, where they could commit without a review? 19:13:47 I think the filter is a good thing, but we definitely need to make it more efficient - i.e., get pull request reviews done a lot more quickly, encourage people to become "team" members for plugins, etc. 19:14:31 hare_brain: If we don't have bandwidth to review, then giving them the false sense of "now I'm done with my part and it's up to the Jenkins project" and disappoint them feels to me like a worse situation 19:15:30 Do you think the problem is worse for plugins or the core, or about the same? 19:15:36 But I don't know. This is all subjective and I don't really have any numbers to back up my feeling that the funnel became narrower 19:15:51 I'm more worried about plugins 19:16:14 We should be reviewing changes to the core, and adding committers there involve other barriers like CLA 19:17:08 IIRC there is some listing all pull requests older then 15 days, what about to extend it to send emails to the users, that the pull requests is pending for more then 15 days and they should consider to ask for commit access and commit it themselfs? 19:17:17 So my suggestion was to come up with some bot that automatically comment on old open unattended pull requests for plugins and write something like "hey, sorry about the delay. Maybe we don't have any committers on this plugin, and it'd be great if you'd be willing to become committers" 19:17:21 #info https://wiki.jenkins-ci.org/display/JENKINS/Pending+Pull+Requests 19:17:42 vjuranek: sounds like the same idea (with different implementations, granted). 19:17:52 yup 19:18:31 Looking at the history of this page might give us more objective numbers. I think this list has grown considerably 19:19:39 Sounds good. 19:19:53 #info the same list in 2011 Sep https://wiki.jenkins-ci.org/pages/viewpage.action?pageId=58002442 19:19:59 * DarkRift bbl 19:20:08 I think the important thing is to increase a sense of ownership. 19:20:29 Yes, that's a good point 19:20:30 Throwing things over the wall can potentially lead to unstable releases. 19:21:16 In that sense maybe we want to somehow start keeping track of "maintainer" more officially? 19:22:06 That might help us signal "volunteers wanted" more easily? 19:22:39 Maybe gamify it. The maintainer is automatically updated to be person with the most commits over a period of time. 19:23:12 If you are the maintainer, and you have a lot of pending pull requests, you lose points. 19:23:25 Hmm 19:23:45 Actually 19:23:46 I was mainly thinking about keeping track of people's intent to maintain it 19:23:50 but that's interesting 19:23:53 but that would also mean, people not knowing how to use the SCM (git) get more credit 19:24:23 ...if every file changed gets its own commit... 19:24:59 So there are a couple of things going on. We want to increase the rate at which pull requests are reviewed and merged. A bottleneck is if there is a single maintainer, and that person is unavailable, that reduces throughput. 19:25:19 If there were more people who were "maintainers" we have better merge capacity. 19:25:56 I think who is a maintainer to be fairly dynamic, so that people can be free to come and go, but the rate of merges can remain high. 19:26:35 I think kohsuke, what you were getting at is a badge about the project itself. Whether it's a maintained or abandoned project. 19:26:50 kohsuke: have you had any chance to look at JENKINS-12647? 19:26:51 yeah, maybe that's what it is 19:26:52 JENKINS-12647:Jetty configuration causes locked files when running tests on Windows, which causes test failures (Open) http://jenkins-ci.org/issue/12647 19:27:03 That should definitely be highlighted so that people can quickly claim maintenance/ownership of a plugin has is in the abandoned state. 19:27:05 I know you've been traveling a lot 19:27:51 Or maybe it's just a matter of producing "your pull requests that the project thinks you should be looking at" list 19:28:28 Where would I go to see that? 19:28:45 currently we have only https://github.com/organizations/jenkinsci/dashboard/pulls 19:29:20 but if it can be somehow combined with your gamification idea and "who committed where recently" idea... 19:29:25 I almost never go to that page. How do we get people into the habit of doing that? 19:30:29 Exactly. So I thought if some program generates personalized notifications for your pull requests... 19:31:10 And make sure it doesn't get lost in the sea of other pull request emails... :) 19:31:28 At that point we can stop sending pull request e-mails 19:31:35 ah, but maybe it doesn't let you stop that 19:31:50 Yeah, and I'm not sure I'd want to have it turn off anyway. 19:32:03 I like the idea of not sending a pull request unless the project thinks you are a good candidate to review it. 19:32:18 abayer: we'll make sure you get all of them :-) 19:32:20 Yeah, that's kind of what I was thinking of with better refinement of team definitions. 19:32:53 this whole area I think is a good thing to think about, but I'm afraid unless someone wants to spend some real cycles, it'll be hard to get something done. 19:33:22 The GitHub guys seem to like us. Is this something we can ping them about to see if they have any ideas of how to make the notifications more relevant? 19:33:31 Maybe they'll have a great idea and just do it. 19:34:23 At the least, I think having a maintained/abandoned badge for each plugin, based on some criteria can help. 19:34:26 Yeah, we can ask them, although I suspect the way this project runs is somewhat unique 19:34:43 Then maybe we need to change a little bit to conform. :) 19:35:06 I can't think of any other orgs with 670 repositories 19:35:48 #action kohsuke to improve the pending pull request list generator to also post comments on old pull requests 19:36:16 I think we should move on to the next topic 19:36:27 wiki page or mailing list thread for the other ideas, if they're also relevant? 19:36:33 (not sure, I joined late) 19:36:51 I thought that was the only topic today. :) 19:37:11 I want to quickly update about JFrog's offer to host our repository 19:37:24 Before switching to that. 19:37:38 Is some automation like Gerrit a possibility? 19:37:44 orrc: I'm happy to start a thread if that helps 19:37:58 I guess I'll do that as an encouragement for devs to look at pull requests 19:38:00 Have it do a merge and test, and if it succeeds, automatically merge it into the turnk? 19:39:07 hare_brain: I've got some code here that does that kind of pull request merge validation 19:39:14 hare_brain: Erm…dunno if we'd want that anyway. 19:39:29 I still think having no human intervention is a bad thing. 19:39:38 At least for new contributors. 19:39:42 We have no human intervention right now in a different way. 19:40:10 Maybe we can run the test but auto-merge only if no action happens for X days? 19:40:20 Yeah, that's fine. 19:40:24 I know the git plugin gets a lot of pull requests where the code can merge but really shouldn't, since it's just cluttering the code with more config options for edge cases, etc. 19:41:16 abayer: doing the automatic validation also helps the reviewer 19:41:25 Oh, automatic validation is a very good thing. 19:41:40 I like the gerrit approach of requiring code review and automatic validation in combination. 19:42:27 OK, I'm willing to move on now. 19:43:01 One more note --- the only thing about this pull request validation merge is that it depends on some proprietary CB plugins 19:43:28 And that reminds me if we'd be willing to run those (and other) proprietary plugins? 19:43:33 #idea Mark plugin projects with maintained/abandoned status to set expectation of how long a pull request may be outstanding 19:43:45 Like template plugin, for example 19:43:55 kohsuke: Never had a problem with that personally. =) I'd want rtyler's thoughts, though. 19:43:57 #idea Track list of who are potential reviewers for a pull request 19:44:03 ... vastly simplifying our plugin projects? 19:44:06 (Just recording the ideas we talked about) 19:44:19 kohsuke: sorry, late (children ...) 19:44:32 #idea Use a tool like Gerrit to do automatic validation and merge after pull requests have been outstanding for X days 19:45:02 ndeloof: No problem. I hope I correctly summarized your conversation with Sacha 19:45:11 right 19:45:18 #topic Hosted Maven repository 19:45:48 So there's an offer from JFrog to host the Maven repository on their hosted Artifactory 19:46:36 It'll be integrated with our LDAP, and all kinds of other measures will be taken to preserve the compatibility, meaning ... 19:46:42 plugin devs will not have to change anything 19:46:52 and we get sync to central and so on. 19:47:01 sounds nice 19:47:19 How nice of them. 19:47:24 What do they want in exchange? :) 19:47:25 I thought it'd be nice to at least do some proof-of-concept with this 19:47:37 I need to dance and sing for them 19:47:40 will port 80 or 443 be available for releases? 19:47:52 No, just kidding :-) I haven't asked 19:47:54 Works for me. 19:48:07 And yeah, getting 80/443 would be key. 19:48:09 But I suspect it'll be logo on the sponsor section, etc, etc. 19:48:33 Slide-O-Mix: yeah, I'm sure it is 19:48:37 Any time we can outsource infrastructure to something more robust, that's a positive. 19:48:46 exactly my thinking 19:48:53 Question! Do shell commands timeout? I've got a build setup that runs a particularly long task, and it's making it as Shell Execution Failed or whatever without actually throwing an error. 19:49:01 that would be great, I currently can't do releases from work :) 19:49:04 monkeysmuggler: let's hold it until we are done with the meeting 19:49:29 #info so if anyone is willing to volunteer with PoC, you'd be very welcome 19:50:10 Otherwise I'll work with them and get back to this meeting when it's demoable 19:50:10 I nominate rtyler. 19:51:01 I already talked to him about this idea and he's OK with this, though I don't know if he's willing to volunteer 19:51:07 I can see him saying "but I don't do Java" 19:51:12 Hahaha 19:51:13 heh 19:51:29 what would it take to help on this? 19:51:37 just do some releases? 19:51:41 #action kohsuke to check if rtyler is willing to spend some time doing hosted artifactory PoC 19:52:00 imod: at this stage realistically it needs to be someone with the infra access 19:52:03 I nominate imod. =) 19:52:06 Oh, right. 19:52:09 Details, details. 19:52:17 :) 19:52:30 later we can solicit some plugin devs to help trying it out 19:52:56 I also can help 19:53:09 * kohsuke looks at abayer because central sync is his pet-peeve 19:53:37 all right, next topic? 19:53:59 #topic next meeting time (but really, this is just a formality) 19:54:17 2/22? 19:54:20 ... because our convention puts it to 2 weeks from now, same time 19:54:32 +1 19:54:44 +1 19:54:52 I won't be able to attend, because I'll be in Tokyo. 19:55:04 but +1 for 2/22 19:55:17 #agreed next meeting is 2/22, the same time 19:55:25 =) 19:55:30 Okiedokie. 19:55:42 Is that "Okiedokie" for Artifactory stuff or for 2/22? 19:55:56 2/22. And I'm in favor of the Artifactory move. 19:56:16 I'll CC imod and abayer to the e-mail 19:56:28 ... so that both of them are in the loop at least 19:56:34 kohsuke when do you leave for Tokyo? 19:56:47 2/14 19:57:04 You took two action items. Will you do anything with those before you leave? 19:57:32 I'll ping rtyler. The other one I suspect I won't be able to 19:58:13 And carry over the action for ndeloof and jieryn about the CloudBees FOSS thing? 19:58:28 Yes 19:58:35 Oh, jieryn was the cafepress discounts 19:58:49 #action jieryn to follow ask cafepress if they discount for non-profits 19:58:52 he's also the main guy behind trying out hosted Jenkins 19:59:06 #action ndeloof jieryn to confirm cloudbees foss requirements for sponsor logo 19:59:32 OK. We done? 19:59:37 Shall I close the meeting? 19:59:44 #endmeeting